Adds filter to data.aws_eip #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this addes the ability to search for EIP’s via tags or other attribute that EIP’s can use in a filter.
This did highlight a known issue with regrads to how terraform eval’s data sources before they should if be the resourse is a computed value. This is only an issue if the data block is referencing a resource that is created at the same time. If referencing a pre exiting resource this does not happen.
the test config testAccDataSourceAwsEipFilterConfig makes a interpol ref to force terraform to eval the data block after the resource has either been created or read in `values = ["${aws_eip.test.tags.Name}”]` see the following links
hashicorp/terraform#10603
hashicorp/terraform#17173
bflad
added
enhancement
richardbowden
changed the title
This was referenced May 28, 2018
|
Any chance to see this merged? In our case it would be very valuable to be able to setup a fixed pool of EIPs, and assign them to instances via a data source. This makes sure we always keep the same EIPs in case we have to open firewalls etc. |
|
curious when will this make it in ? |
bflad
added a commit
that referenced
this pull request
Nov 13, 2018
``` --- PASS: TestAccDataSourceAwsEip_PublicIP_EC2Classic (8.56s) --- PASS: TestAccDataSourceAwsEip_PublicIP_VPC (11.76s) --- PASS: TestAccDataSourceAwsEip_Id (11.79s) --- PASS: TestAccDataSourceAwsEip_Tags (12.45s) --- PASS: TestAccDataSourceAwsEip_Filter (12.58s) ```
bflad
added a commit
that referenced
this pull request
Nov 13, 2018
|
This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #3423
this is based of PR "#3522"
Had to fix the failing tests before I could submit this PR.
this addes the ability to search for EIP’s via tags or other attribute that EIP’s can use in a filter.
This did highlight a known issue with regrads to how terraform eval’s data sources before they should if be the resourse is a computed value. This is only an issue if the data block is referencing a resource that is created at the same time. If referencing a pre exiting resource this does not happen.
the test config testAccDataSourceAwsEipFilterConfig makes a interpol ref to force terraform to eval the data block after the resource has either been created or read in
values = ["${aws_eip.test.tags.Name}”]see the following linkshashicorp/terraform#10603
hashicorp/terraform#17173