Add support for tags and filters to aws_eip data source

[UnsafePointer]

This should close #2932

[UnsafePointer]

Hey 👋, this is my first contribution and a bit of help would be really appreciated. I can't make the acceptance tests pass, I get the following:

testing.go:518: Step 0 error: Error refreshing: 2 error(s) occurred:

                * data.aws_eip.by_filter: 1 error(s) occurred:

                * data.aws_eip.by_filter: data.aws_eip.by_filter: no matching Elastic IP found
                * data.aws_eip.by_tags: 1 error(s) occurred:

                * data.aws_eip.by_tags: data.aws_eip.by_tags: no matching Elastic IP found

As far as I can understand, the data sources I added can't match the Elastic IP resource created. Using the exact same code works if I compile my branch and deploy it as a plugin. What am I missing?

[UnsafePointer]

Managed to found the error myself. I believe the data source was trying to fetch the resource before it was created. Fixed it by adding a reference of the resource to the data source:

eip_tags {
  Name = "${aws_eip.test.tags["Name"]}"
}

I think this should be ready for review now, I added tests and updated the docs.

[UnsafePointer]

@bflad is there anything I can do to move this forward?

[UnsafePointer]

My bad, I didn't notice that #2932 and #3525 are tackling this already.

Closing in favour of those.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!