Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ecs_service: Remove deprecated placement_strategy configuration block #7712

Merged
merged 1 commit into from
Feb 26, 2019
Merged

resource/aws_ecs_service: Remove deprecated placement_strategy configuration block #7712

merged 1 commit into from
Feb 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Feb 25, 2019

Closes #7687

Output from acceptance testing:

--- PASS: TestAccAWSEcsService_basicImport (41.70s)
--- PASS: TestAccAWSEcsService_disappears (19.59s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (280.20s)
--- PASS: TestAccAWSEcsService_ManagedTags (40.17s)
--- PASS: TestAccAWSEcsService_PropagateTags (51.77s)
--- PASS: TestAccAWSEcsService_Tags (52.20s)
--- PASS: TestAccAWSEcsService_withAlb (230.24s)
--- PASS: TestAccAWSEcsService_withARN (45.47s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (39.76s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (11.07s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (251.33s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (21.32s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (14.64s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (39.81s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (34.30s)
--- PASS: TestAccAWSEcsService_withIamRole (157.58s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (60.52s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (105.95s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (116.83s)
--- PASS: TestAccAWSEcsService_withLbChanges (241.52s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (18.51s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (37.03s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (79.48s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (60.43s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (17.00s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (138.96s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (139.06s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (21.10s)

@bflad bflad added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/ecs Issues and PRs that pertain to the ecs service. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 25, 2019
@bflad bflad added this to the v2.0.0 milestone Feb 25, 2019
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 25, 2019
@bflad bflad mentioned this pull request Feb 25, 2019
Closed
@bflad
resource/aws_ecs_service: Remove deprecated placement_strategy config…
5574c38 
…uration block

Reference: #7687

Output from acceptance testing:

```
--- PASS: TestAccAWSEcsService_basicImport (41.70s)
--- PASS: TestAccAWSEcsService_disappears (19.59s)
--- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (280.20s)
--- PASS: TestAccAWSEcsService_ManagedTags (40.17s)
--- PASS: TestAccAWSEcsService_PropagateTags (51.77s)
--- PASS: TestAccAWSEcsService_Tags (52.20s)
--- PASS: TestAccAWSEcsService_withAlb (230.24s)
--- PASS: TestAccAWSEcsService_withARN (45.47s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (39.76s)
--- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (11.07s)
--- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (251.33s)
--- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (21.32s)
--- PASS: TestAccAWSEcsService_withDeploymentValues (14.64s)
--- PASS: TestAccAWSEcsService_withEcsClusterName (39.81s)
--- PASS: TestAccAWSEcsService_withFamilyAndRevision (34.30s)
--- PASS: TestAccAWSEcsService_withIamRole (157.58s)
--- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (60.52s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargate (105.95s)
--- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (116.83s)
--- PASS: TestAccAWSEcsService_withLbChanges (241.52s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints (18.51s)
--- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (37.03s)
--- PASS: TestAccAWSEcsService_withPlacementStrategy (79.48s)
--- PASS: TestAccAWSEcsService_withRenamedCluster (60.43s)
--- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (17.00s)
--- PASS: TestAccAWSEcsService_withServiceRegistries (138.96s)
--- PASS: TestAccAWSEcsService_withServiceRegistries_container (139.06s)
--- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (21.10s)
```
@bflad bflad force-pushed the td-aws_ecs_service-remove-deprecated branch from 970db99 to 5574c38 Compare February 25, 2019 17:01
@bflad bflad requested a review from a team February 26, 2019 15:39
@bflad bflad merged commit 332aca0 into master Feb 26, 2019
@bflad bflad deleted the td-aws_ecs_service-remove-deprecated branch February 26, 2019 22:53
bflad added a commit that referenced this pull request Feb 26, 2019
@bflad
Update CHANGELOG for #7712
311a8cc
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paultyng paultyng paultyng approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/M Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

[Version 2 Release] resource/aws_ecs_service: Remove deprecated placement_strategy argument
2 participants
@bflad @paultyng