-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Version 2 Release] resource/aws_ecs_service: Remove deprecated placement_strategy argument #7687
Labels
service/ecs
Issues and PRs that pertain to the ecs service.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
Milestone
Comments
bflad
added
service/ecs
Issues and PRs that pertain to the ecs service.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
labels
Feb 24, 2019
bflad
added a commit
that referenced
this issue
Feb 25, 2019
…uration block Reference: #7687 Output from acceptance testing: ``` --- PASS: TestAccAWSEcsService_basicImport (41.70s) --- PASS: TestAccAWSEcsService_disappears (19.59s) --- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (280.20s) --- PASS: TestAccAWSEcsService_ManagedTags (40.17s) --- PASS: TestAccAWSEcsService_PropagateTags (51.77s) --- PASS: TestAccAWSEcsService_Tags (52.20s) --- PASS: TestAccAWSEcsService_withAlb (230.24s) --- PASS: TestAccAWSEcsService_withARN (45.47s) --- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (39.76s) --- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (11.07s) --- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (251.33s) --- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (21.32s) --- PASS: TestAccAWSEcsService_withDeploymentValues (14.64s) --- PASS: TestAccAWSEcsService_withEcsClusterName (39.81s) --- PASS: TestAccAWSEcsService_withFamilyAndRevision (34.30s) --- PASS: TestAccAWSEcsService_withIamRole (157.58s) --- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (60.52s) --- PASS: TestAccAWSEcsService_withLaunchTypeFargate (105.95s) --- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (116.83s) --- PASS: TestAccAWSEcsService_withLbChanges (241.52s) --- PASS: TestAccAWSEcsService_withPlacementConstraints (18.51s) --- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (37.03s) --- PASS: TestAccAWSEcsService_withPlacementStrategy (79.48s) --- PASS: TestAccAWSEcsService_withRenamedCluster (60.43s) --- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (17.00s) --- PASS: TestAccAWSEcsService_withServiceRegistries (138.96s) --- PASS: TestAccAWSEcsService_withServiceRegistries_container (139.06s) --- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (21.10s) ```
Pull request submitted: #7712 |
bflad
added a commit
that referenced
this issue
Feb 25, 2019
…uration block Reference: #7687 Output from acceptance testing: ``` --- PASS: TestAccAWSEcsService_basicImport (41.70s) --- PASS: TestAccAWSEcsService_disappears (19.59s) --- PASS: TestAccAWSEcsService_healthCheckGracePeriodSeconds (280.20s) --- PASS: TestAccAWSEcsService_ManagedTags (40.17s) --- PASS: TestAccAWSEcsService_PropagateTags (51.77s) --- PASS: TestAccAWSEcsService_Tags (52.20s) --- PASS: TestAccAWSEcsService_withAlb (230.24s) --- PASS: TestAccAWSEcsService_withARN (45.47s) --- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategy (39.76s) --- PASS: TestAccAWSEcsService_withDaemonSchedulingStrategySetDeploymentMinimum (11.07s) --- PASS: TestAccAWSEcsService_withDeploymentController_Type_CodeDeploy (251.33s) --- PASS: TestAccAWSEcsService_withDeploymentMinimumZeroMaximumOneHundred (21.32s) --- PASS: TestAccAWSEcsService_withDeploymentValues (14.64s) --- PASS: TestAccAWSEcsService_withEcsClusterName (39.81s) --- PASS: TestAccAWSEcsService_withFamilyAndRevision (34.30s) --- PASS: TestAccAWSEcsService_withIamRole (157.58s) --- PASS: TestAccAWSEcsService_withLaunchTypeEC2AndNetworkConfiguration (60.52s) --- PASS: TestAccAWSEcsService_withLaunchTypeFargate (105.95s) --- PASS: TestAccAWSEcsService_withLaunchTypeFargateAndPlatformVersion (116.83s) --- PASS: TestAccAWSEcsService_withLbChanges (241.52s) --- PASS: TestAccAWSEcsService_withPlacementConstraints (18.51s) --- PASS: TestAccAWSEcsService_withPlacementConstraints_emptyExpression (37.03s) --- PASS: TestAccAWSEcsService_withPlacementStrategy (79.48s) --- PASS: TestAccAWSEcsService_withRenamedCluster (60.43s) --- PASS: TestAccAWSEcsService_withReplicaSchedulingStrategy (17.00s) --- PASS: TestAccAWSEcsService_withServiceRegistries (138.96s) --- PASS: TestAccAWSEcsService_withServiceRegistries_container (139.06s) --- PASS: TestAccAWSEcsService_withUnnormalizedPlacementStrategy (21.10s) ```
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
service/ecs
Issues and PRs that pertain to the ecs service.
technical-debt
Addresses areas of the codebase that need refactoring or redesign.
Description
Tracking issue for https://www.terraform.io/docs/providers/aws/guides/version-2-upgrade.html#resource-aws_ecs_service
placement_strategy Argument Removal
Switch your Terraform configuration to the
ordered_placement_strategy
argument instead. It behaves similar to the previousplacement_strategy
argument, however the ordering of the configurations in Terraform is now reflected in the service where previously it was indeterminate.For example, given this previous configuration:
An updated configuration:
Additional References
The text was updated successfully, but these errors were encountered: