r/aws_backup_vault: Adding resource to manage AWS Backup vaults

[slapula]

Reference #7166

Changes proposed in this pull request:

• Adding resource to manage AWS Backup vaults: aws_backup_vault

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupVault_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAwsBackupVault_ -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAwsBackupVault_basic
=== PAUSE TestAccAwsBackupVault_basic
=== RUN   TestAccAwsBackupVault_withKmsKey
=== PAUSE TestAccAwsBackupVault_withKmsKey
=== RUN   TestAccAwsBackupVault_withTags
=== PAUSE TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_basic
=== CONT  TestAccAwsBackupVault_withTags
=== CONT  TestAccAwsBackupVault_withKmsKey
--- PASS: TestAccAwsBackupVault_withTags (8.01s)
--- PASS: TestAccAwsBackupVault_basic (8.10s)
--- PASS: TestAccAwsBackupVault_withKmsKey (33.02s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	33.050s

[slapula]

This is a quick write up of this resource without any proper testing yet. This PR should be marked as a work in progress until either #7164 or #7197 are merged into master.

[slapula]

This is what CI is failing on:

529.30s$ make lint
==> Checking source code against linters...
WARNING: deadline exceeded by linter staticcheck (try increasing --deadline)
WARNING: deadline exceeded by linter unparam (try increasing --deadline)
make: *** [lint] Error 2
The command "make lint" exited with 2.

Not sure what that's about. Running the linters locally don't return any errors for me.

[slapula]

I'm aware that the tests need to be fleshed out more here as well.

[slapula]

I think this is ready for review now.

[bflad]

Hey @slapula 😄 Thanks for submitting this. Please see the below initial feedback and let us know if you have any questions or do not have time to implement these items.

[slapula]

@bflad This is ready for round two!

[bflad]

Hey @slapula, a few more little things then good to go. Thanks!

[bflad]

It looks like there is a mismatch between the regex (contains a hyphen and no underscore) and the description (contains underscore and no hyphen). The API reference doesn't clear this up too well 🙁

They consist of lowercase letters, numbers, and hyphens.
Pattern: ^[a-zA-Z0-9\-\_\.]{1,50}$

[slapula]

Yeah, that's....weird. It allows periods too? Um, okay. I'm going to just lift the API information and use it here even if it's not super clear.

[bflad]

LGTM, thanks @slapula! 🚀

--- PASS: TestAccAwsBackupVault_basic (4.35s)
--- PASS: TestAccAwsBackupVault_withTags (4.70s)
--- PASS: TestAccAwsBackupVault_withKmsKey (23.39s)

[bflad]

This has been released in version 1.58.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[apeeters]

Documentation available here: https://www.terraform.io/docs/providers/aws/r/backup_vault.html

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!