Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_subnet_ids: Add filtering #5038

Merged
merged 1 commit into from
Jun 29, 2018
Merged

d/aws_subnet_ids: Add filtering #5038

merged 1 commit into from
Jun 29, 2018

Conversation

kl4w
Copy link
Contributor

@kl4w kl4w commented Jun 29, 2018

Changes proposed in this pull request:

  • Add filtering to subnet ids data source

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSubnetIDs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsSubnetIDs -timeout 120m
=== RUN   TestAccDataSourceAwsSubnetIDs
--- PASS: TestAccDataSourceAwsSubnetIDs (37.54s)
=== RUN   TestAccDataSourceAwsSubnetIDs_filter
--- PASS: TestAccDataSourceAwsSubnetIDs_filter (26.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	63.861s

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Jun 29, 2018
@kl4w kl4w changed the title Add filtering to subnet ids data source d/aws_subnet_ids: Add filtering Jun 29, 2018
@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 29, 2018
@bflad bflad added this to the v1.26.0 milestone Jun 29, 2018
bflad
bflad approved these changes Jun 29, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- we can also make vpc_id optional at some point. 🚀

2 tests passed (all tests)
=== RUN   TestAccDataSourceAwsSubnetIDs_filter
--- PASS: TestAccDataSourceAwsSubnetIDs_filter (10.14s)
=== RUN   TestAccDataSourceAwsSubnetIDs
--- PASS: TestAccDataSourceAwsSubnetIDs (14.46s)

@bflad bflad merged commit e73a028 into hashicorp:master Jun 29, 2018
bflad added a commit that referenced this pull request Jun 29, 2018
@bflad
Update CHANGELOG for #5038
2b7d3da
@kl4w kl4w deleted the filter-subnet-ids-data-source branch June 30, 2018 02:17
@bflad
Copy link
Contributor

bflad commented Jul 4, 2018

This has been released in version 1.26.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@bflad bflad mentioned this pull request Jul 10, 2018
Closed
@ghost
Copy link

ghost commented Apr 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kl4w @bflad