d/aws_subnet_ids: filter by availability zone

[kl4w]

This should help with #3471

make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsSubnetIDs'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccDataSourceAwsSubnetIDs -timeout 120m
=== RUN   TestAccDataSourceAwsSubnetIDs
--- PASS: TestAccDataSourceAwsSubnetIDs (34.54s)
=== RUN   TestAccDataSourceAwsSubnetIDsAvailabilityZone
--- PASS: TestAccDataSourceAwsSubnetIDsAvailabilityZone (23.73s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	58.312s

[bflad]

@kl4w Instead of implementing the one-off handling of availability_zone, what if we instead supported the generic EC2 filtering?

Its actually pretty easy to implement:

// in the schema
"filter": ec2CustomFiltersSchema(),

// in the read function
	if v, ok := d.GetOk("filter"); ok {
		req.Filters = append(req.Filters, buildEC2CustomFilterList(
			v.(*schema.Set),
		)...)
	}

See the aws_network_acls data source code and documentation for ideas 😄 What do you think?

[kl4w]

@bflad agree with you there. I'm going to close out this PR and submit a separate one.

[wsandin]

@kl4w Did you create a new PR?

[bflad]

@wsandin EC2 filtering (via the filter argument) for the aws_subnet_ids data source was added in #5038 and released in version 1.26.0 of the AWS provider.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!