r/appautoscaling_policy: Add support for DynamoDB

[radeksimko]

Closes #866
Closes #888
Closes #919
Closes #920

I don't like squashing too many bugfixes & features into one PR, but fixing #920 was the only way to make acceptance tests pass in my case. 🤷‍♂️

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAWSAppautoScalingPolicy_ -timeout 120m
=== RUN   TestAccAWSAppautoScalingPolicy_basic
--- PASS: TestAccAWSAppautoScalingPolicy_basic (122.74s)
=== RUN   TestAccAWSAppautoScalingPolicy_nestedSchema
--- PASS: TestAccAWSAppautoScalingPolicy_nestedSchema (126.13s)
=== RUN   TestAccAWSAppautoScalingPolicy_spotFleetRequest
--- PASS: TestAccAWSAppautoScalingPolicy_spotFleetRequest (92.60s)
=== RUN   TestAccAWSAppautoScalingPolicy_dynamoDb
--- PASS: TestAccAWSAppautoScalingPolicy_dynamoDb (62.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	404.289s

---

In regards to customized_metric_specification - I wasn't able to find any example to test this part of the API/schema at all. It seems to be open only to an undefined small group of AWS customers.

[catsby]

👍

[bflad]

FYI this shipped with only partial support. A single DynamoDB resource can have multiple scaling dimension targets: read and write. The aws_appautoscaling_target resource id field only includes the resource. See: #1765 (comment)

[anbotero]

I’m having the same issue as @bflad. Have you created another issue for this? I cannot find anything, so not sure if I should create one.

When having multiple targets (read and write, for example) and multiple policies, whenever we try to plan again, it will always detect changes, and it will replace one of the targets for the other (and hence the policies as well). This is because even though both targets have different name, it seems Terraform assigns the same id to both based on the resource_id.

[binarylogic]

I've also confirmed @anbotero's issue. It is not possible to have both read and write targets for a single dynamodb table.

[anbotero]

@binarylogic I know this happened not too long ago, but I think this was fixed. You have to update/redownload the provider folder. Like, the .terraform folder created when you first ran terraform init, just delete it and redownload it again. It should fix it.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!