Add Tag Support to Resource Group Resource

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #7109

Release note for CHANGELOG:

- resource/resource_aws_resourcegroups_group: Add `tags` argument.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSResourceGroup_'

=== RUN   TestAccAWSResourceGroup_basic
=== PAUSE TestAccAWSResourceGroup_basic
=== CONT  TestAccAWSResourceGroup_basic
--- PASS: TestAccAWSResourceGroup_basic (85.00s)
=== RUN   TestAccAWSResourceGroup_tags
=== PAUSE TestAccAWSResourceGroup_tags
=== CONT  TestAccAWSResourceGroup_tags
--- PASS: TestAccAWSResourceGroup_tags (114.05s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	139.697s

...

I saw that there is pending PR for this #7811 which i only realised only after i was done with this.
this refactors the tests as well as uses the keyvaluetags lib

[bflad]

Hi @DrFaust92 👋 Thanks for submitting this one as well.

Looks like there's a bit of a backlog for adding tagging for this resource. The maintainers prefer working with contributions in their submission order to be fair to contributors. In this case, that means we should try working with the original author (even before #7811 there is #7774) to either help review their contribution, asking them to close their contribution, or if they are unresponsive to submit a fix on top of their commits unless they close their pull request so they receive contributing credit.

Before we even go through that though, it might be best to get the keyvaluetags updates submitted separately since they appear to be in merge conflict already in this pull request. To prevent this situation as well as help human readers, we would encourage alphabetizing additions to switch statements and import declarations.

Please reach out with any questions.

[DrFaust92]

@bflad, ill open up a separate PR for the keyvaluetags change for this resource and reach out to other contributors for this.
ill keep this open for now and close if the change will be merged to another PR
thanks!

[DrFaust92]

fixed merge conflicts

$ make testacc TESTARGS='-run=TestAccAWSResourceGroup_'

=== RUN   TestAccAWSResourceGroup_basic
=== PAUSE TestAccAWSResourceGroup_basic
=== CONT  TestAccAWSResourceGroup_basic
--- PASS: TestAccAWSResourceGroup_basic (67.41s)
=== RUN   TestAccAWSResourceGroup_tags
=== PAUSE TestAccAWSResourceGroup_tags
=== CONT  TestAccAWSResourceGroup_tags
--- PASS: TestAccAWSResourceGroup_tags (94.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	181.002s

[rsareth]

Please, merge it!

[bflad]

Looks good, thanks @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSResourceGroup_basic (14.51s)
--- PASS: TestAccAWSResourceGroup_tags (20.03s)

[bflad]

Nit: This acceptance testing does not need to verify anything with this attribute, so it should omitted or hardcoded in the test configurations.

[bflad]

Nit: We prefer to hardcode values like these into the test configurations so they can more easily be copy-pasted for manual Terraform CLI usage.

[ghost]

This has been released in version 2.39.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!