Add tag for resource groups #7811
Conversation
ghost
added
size/M
| @@ -176,3 +216,45 @@ func resourceAwsResourceGroupsGroupDelete(d *schema.ResourceData, meta interface | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func tagsToMapRG(ts map[string]interface{}) map[string]string { | |||
There was a problem hiding this comment.
I think you can reuse the functionality in tagsGeneric.go here.
There was a problem hiding this comment.
Many thanks !!!! Good to know since I'm struggle with the Tag function !!
|
Hi @vnguyen7 👋There is a previously opened pull request for this functionality: #7774. In the situation, the maintainers would prefer if you worked with the previous contributor by either including their contributions, commenting/reviewing their contribution, or discussed with them using this pull request instead. Thanks for your understanding as we try to respect all contributions. |
bflad
added
the
enhancement
|
Hi @vnguyen7 👋 Thank you for working on this and sorry it was previously lingering. As @DrFaust92 is mentioning above, there have been some consistency changes and simplifications to how to implement resource tagging into the Terraform AWS Provider codebase, which can be found in the Contributing Guide using a new internal Since we didn't see a response to the above and we would prefer to implement the newer methodology, we are going to opt to close this. Thanks again for your contribution here and let us know if you have any questions. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Add tags for resource group related to #7109 in order to fix from PR #7774 of joestump. (one last test )