Move evaluation impl to under the terraform package #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wata727
force-pushed
the
move_eval_to_terraform
branch
4 times, most recently
from
fec6d69 to
b1c12e0
Compare
wata727
force-pushed
the
move_eval_to_terraform
branch
from
b1c12e0 to
fa7c6b2
Compare
This was referenced Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just refactoring. Previously,
terraform.Evaluatorwas exactly the same as Terraform's, so we needed anEvaluateExprfunction to wrap it.But now
terraform.Evaluatoris a fork of Terraform, so we can have TFLint-specific logic (e.g. ignoring unsupported references) here. Slim down the tflint package by moving some evaluation-related implementations under the terraform package.