Ignore invalid references in referencesInExpr #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1474
All expressions are now handled by
WalkExpressionsin #1432, so there are cases where reference parsing fails. For example,ignore_changescontains various keywords, which are invalid references.Often these keywords are not expected and are ignored by
referencesInExpr. However, if the name conflicts with an existing reference such asdataorterraform, it may be misidentified as a valid reference and fail to parse.This PR changes it so that it doesn't return diagnostics if it fails to parse, even for valid references like
dataandterraform. This might make it impossible to detect errors in valid references, but checking references is not the responsibility of this rule, so it makes sense to ignore them here.