-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #28 - RegionInstanceGroupManager is forced to be re-created - fix. #37
Conversation
…ced to be re-created - fix.
@pksmall I'm not sure this is a sufficient fix, as it would prevent people from updating the desired zones of a MIG after creating it. |
@morgante Agree, but this will have to change:
to false I added to a test project distribution_policy_zones by groups and got same error. |
I'm still unclear what is happening here though. Without this, is Terraform claiming that the distribution zones have changed with every apply (even when they are untouched)? |
@morgante Exactly,
this definition is not constant for Terraform. Every apply Terraform overwrites a new. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks. This does seem like the only workable fix unfortunately.
Could you add a note to the README and CHANGELOG that you will have to force recreation yourself if you want to change distribution zones?
…ced to be re-created - fix.
…ced to be re-created - fix.
@morgante sure. If you accept this fix, it would be nice to remove the unnecessary code from the module. |
Co-Authored-By: Morgante Pell <[email protected]>
Co-Authored-By: Morgante Pell <[email protected]>
Fixes #28
Highlight:
ignore using lifecycle