Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add frontend and backend modules #461

Merged
merged 4 commits into from
Oct 29, 2024
Merged

feat: Add frontend and backend modules #461

merged 4 commits into from
Oct 29, 2024

Conversation

q2w
Copy link
Collaborator

@q2w q2w commented Oct 21, 2024 •
edited
Loading

@q2w q2w force-pushed the new_submodules branch 2 times, most recently from 5040b24 to 95768da Compare October 24, 2024 04:26
@q2w q2w changed the title feat: [DO NO REVIEW] Add lb-http-frontend and lb-http-backend modules feat: Add lb-http-frontend and lb-http-backend modules Oct 24, 2024
@q2w q2w marked this pull request as ready for review October 24, 2024 06:19
@q2w q2w requested review from imrannayer and a team as code owners October 24, 2024 06:19
@q2w q2w requested a review from bharathkkb October 24, 2024 06:20
@q2w
Copy link
Collaborator Author

q2w commented Oct 25, 2024

/gcbrun

bharathkkb
bharathkkb approved these changes Oct 29, 2024
View reviewed changes
examples/lb-http-separate-frontend-and-backend/variables.tf Outdated Show resolved Hide resolved
examples/lb-http-separate-frontend-and-backend/variables.tf Outdated Show resolved Hide resolved
modules/lb-http-backend/metadata.yaml Outdated Show resolved Hide resolved
@q2w q2w changed the title feat: Add lb-http-frontend and lb-http-backend modules feat: Add frontend and backend modules Oct 29, 2024
@q2w q2w merged commit 05fdae5 into terraform-google-modules:master Oct 29, 2024
4 checks passed
@release-please release-please bot mentioned this pull request Oct 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@imrannayer imrannayer Awaiting requested review from imrannayer imrannayer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@q2w @bharathkkb