Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use for_each instead of count #118

Conversation

mehdicopter
Copy link

Hello,
Please be indulgent this is my first PR in a terraform module.
I know there might be work left to do.
I invite you to review my PR and improve my work :)

Thanks

@mehdicopter mehdicopter requested a review from a team as a code owner March 7, 2024 18:41
Copy link

google-cla bot commented Mar 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mehdicopter!

Prior to review, can you please address the lint findings.

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Jun 24, 2024
@github-actions github-actions bot closed this Jul 2, 2024
@mehdicopter
Copy link
Author

Reopen please

@apeabody apeabody removed the Stale label Jul 3, 2024
@apeabody apeabody reopened this Jul 3, 2024
@mehdicopter
Copy link
Author

I'll take care of conflicts asap

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Sep 10, 2024
@github-actions github-actions bot closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants