-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update tags for default resources to correct spurious plan diffs #730
fix: Update tags for default resources to correct spurious plan diffs #730
Conversation
one of these days I'll get the title right on the first go 😅 |
should be ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Now, when we don't have format("%s", ...)
let's hope that nobody calls their VPC true
which will be interpreted as a boolean in tags :)
@antonbabenko should be all set now if you get some time to take another 👀 |
### [3.11.3](v3.11.2...v3.11.3) (2022-01-13) ### Bug Fixes * Update tags for default resources to correct spurious plan diffs ([#730](#730)) ([d1adf74](d1adf74))
This PR is included in version 3.11.3 🎉 |
### [3.11.3](terraform-aws-modules/terraform-aws-vpc@v3.11.2...v3.11.3) (2022-01-13) ### Bug Fixes * Update tags for default resources to correct spurious plan diffs ([terraform-aws-modules#730](terraform-aws-modules#730)) ([d1adf74](terraform-aws-modules@d1adf74))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
default_xxx_name
default values changed tonull
; still works the same due to use ofcoalesce(...)
coalesce(var.default_xxx_name, "${var.name}-default")
except fordefault_vpc_name
because its not tied to this module (aka - created by this module)default_route_table_name
to match other default resource conventions (tag)default_security_group_ingress
anddefault_security_group_egress
values to[]
; usingnull
will fail - updated and tested insimple-vpc
- does not affect users because in order for this to work for them they will have had to set the rules so its a no-op for users. This also matches the default route table routes values as wellformat(...)
vpc_id
to usetry()
; replace nearly all instances ofaws_vpc.this[0].id
withlocal.vpc_id
except for the CIDR block associationlocal.nat_gateway_ips
hack now that issue is resolved and we are requiring min version of 0.13.1Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
projectscomplete-vpc
andsimple-vpc