Fix #433 - Add missing tags to EIGW

[gillg]

Description

Fix missing tags for Egress only internet gateway (#433 )
Reuse tags_igw as custom tags

Motivation and Context

Full empty tags on AWS console, no name, nothing...

Breaking Changes

Nothing

How Has This Been Tested?

Run an apply again to add tags

[antonbabenko]

Please make sure that you update versions.tf accordingly.

https://github.com/terraform-providers/terraform-provider-aws/blob/master/CHANGELOG.md#2570-april-09-2020

[vfoucault]

Could be good to add a more meaningful tag Name for Gateways.

Also, could worth the shot to add the tag name to all gateways where is is missing (nat_gateway...)

[gillg]

Hi, thanks for your feedbacks.

@antonbabenko I don't understand why version.tf has a link ? I just create my fork today, so everything should be ok... ? Maybe I missed something ?

@vfoucault The name could be improved, but in my opinion, remember resource type in name is useless, because you already know the resource type when you view / request it.
Moreover, you can override completly Name if you want with igw_tags.
What is opinion for other reviewers about that ?

[gillg]

hum... @antonbabenko finaly I understand your alert 😅 It's a very fresh feature, I don't thought !
Many thanks for your eyes.
I updated it

[antonbabenko]

The feature you are adding in this PR was added to Terraform AWS provider recently so minimum required version of AWS provider should be updated to ~> 2.57 here - https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/versions.tf#L5

[DrFaust92]

duplicate of #430 :<

[antonbabenko]

This has been just fixed in #430 and available in v2.40.0.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.