Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add route to 0.0.0.0/0 & ::/0 (when IPv6 is enabled) on all public route tables #1100

Conversation

abohne
Copy link
Contributor

@abohne abohne commented Jul 2, 2024

Description

Makes the count on aws_route dynamic instead of fixed at 1

Motivation and Context

Fixes #1087

Breaking Changes

Not that I'm aware of.

How Has This Been Tested?

  • I have tested and validated these changes in a VPC in my environment that have a single public route table as well as another VPC that has multiple public route tables
  • I have executed pre-commit run -a on my pull request

@abohne abohne changed the title Fix logic for adding default route on public route tables fix: Add default route on all public route tables Jul 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 2, 2024
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs changed the title fix: Add default route on all public route tables fix: Add route to 0.0.0.0/0/::/0 on all public route tables Aug 3, 2024
@bryantbiggs bryantbiggs changed the title fix: Add route to 0.0.0.0/0/::/0 on all public route tables fix: Add route to 0.0.0.0/0 & ::/0 on all public route tables Aug 3, 2024
@bryantbiggs bryantbiggs changed the title fix: Add route to 0.0.0.0/0 & ::/0 on all public route tables feat: Add route to 0.0.0.0/0 & ::/0 (when IPv6 is enabled) on all public route tables Aug 3, 2024
@bryantbiggs bryantbiggs merged commit b3e7803 into terraform-aws-modules:master Aug 3, 2024
21 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 3, 2024
## [5.11.0](v5.10.0...v5.11.0) (2024-08-03)

### Features

* Add route to `0.0.0.0/0` & `::/0` (when IPv6 is enabled) on all public route tables ([#1100](#1100)) ([b3e7803](b3e7803))
@antonbabenko
Copy link
Member

This PR is included in version 5.11.0 🎉

Copy link

github-actions bot commented Sep 3, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using create_multiple_public_route_tables = true only creates an internet gateway route on one route table.
3 participants