Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Always diff in transit_gateway_default_route_table_association #91

Closed
wants to merge 1 commit into from

Conversation

vainkop
Copy link

@vainkop vainkop commented Nov 17, 2022

Description

Implements a workaround for always diff in
transit_gateway_default_route_table_association = true -> false

This workaround was provided in hashicorp/terraform-provider-aws#8383 (comment)
but lifecycle can be used only inside a resource which means that only the owner of the module can implement it or you have to fork the module which is of course undesired.

Motivation and Context

Fixes #90

How Has This Been Tested?

I've forked the module repo & tested it in my private deployment.

@vainkop vainkop changed the title Fix: always diff in transit_gateway_default_route_table_association fix: always diff in transit_gateway_default_route_table_association Nov 17, 2022
@vainkop vainkop changed the title fix: always diff in transit_gateway_default_route_table_association fix: Always diff in transit_gateway_default_route_table_association Nov 17, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 18, 2022
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Dec 28, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

always diff on transit_gateway_default_route_table_association = false -> true
1 participant