Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run update_groups.sh and apply terraform-docs globally #84

Closed

Conversation

robinbowes
Copy link
Contributor

I noticed discrepancies when I ran update_groups.sh and applied the terraform-docs pre-commit hook.

This change is the result of running pre-commit run -a terraform_docs in the repo.

@antonbabenko
Copy link
Member

Yes, this is because you're using the latest version of terraform-docs, which has been updated by @metmajer.

I have applied the same fix and released a new version - v2.9.0.

Thanks for heads up!

@metmajer
Copy link

@robinbowes by the way, terraform-docs now supports an option --with-aggregate-type-defaults to render default values of types list and map into your documentation.

@antonbabenko I am working on a backwards-compatible solution to integrate these features into your github.com/antonbabenko/pre-commit-terraform (#23).

@antonbabenko
Copy link
Member

I saw it there but didn't find time to comment yet.

@robinbowes robinbowes deleted the update_all_README.md branch October 17, 2018 13:15
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants