Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add identifier output #496

Closed
wants to merge 2 commits into from

Conversation

daroga0002
Copy link
Contributor

Description

It solves #495

Motivation and Context

Because changes in terraform provider v5
exactly:

resource/aws_db_instance: id is no longer the AWS database identifier - id is now the dbi-resource-id. Refer to identifier instead of id to use the database's identifier 

there is problem with setting a replicated RDS because db_instance_id is returning dbi-resource-id and replicate_source_db require identifier of database.

Breaking Changes

No it is adding a output which is available very long in terraform provider v2, v3 and v4

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@daroga0002 daroga0002 changed the title add identifier output feat: add identifier output Jun 1, 2023
@daroga0002
Copy link
Contributor Author

CI is failing because issue with vpc module. I have created #497 to solve this

@daroga0002 daroga0002 changed the title feat: add identifier output feat: Add identifier output Jun 1, 2023
@antonbabenko
Copy link
Member

This issue has been resolved in version 6.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants