Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for Security Hub #242

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

kaykhan
Copy link

@kaykhan kaykhan commented Nov 15, 2024

Description

Adding support for parsing of security hub messages into a readable slack message.

{
  "detail-type": ["Security Hub Findings - Imported"],
  "source": ["aws.securityhub"]
}

image

Examples:
image

image

Motivation and Context

#207
#221

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@kaykhan kaykhan changed the title Support for Security Hub feat: Support for Security Hub Nov 15, 2024
@bryantbiggs bryantbiggs marked this pull request as draft November 15, 2024 15:58
@kaykhan kaykhan marked this pull request as ready for review December 2, 2024 09:35
Copy link

github-actions bot commented Jan 2, 2025

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 2, 2025
@kaykhan
Copy link
Author

kaykhan commented Jan 2, 2025

This is ready for a review

@github-actions github-actions bot removed the stale label Jan 3, 2025
@bryantbiggs
Copy link
Member

CI failed check needs to be remediated

@kaykhan
Copy link
Author

kaykhan commented Jan 7, 2025

CI failed check needs to be remediated

Fixed the majority of them - some of the linting issue i believe are not a result of my changes. Especially

/notify_slack.py:506:1: C901 'get_slack_message_payload' is too complex (11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants