fix: Correct assume role permissions for SNS service to assume IAM role #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwarajBaral
changed the title
SwarajBaral
changed the title
bryantbiggs
reviewed
Mar 21, 2024
| @@ -31,7 +31,16 @@ resource "aws_iam_role" "sns_feedback_role" { | |||
| path = var.sns_topic_feedback_role_path | |||
| force_detach_policies = var.sns_topic_feedback_role_force_detach_policies | |||
| permissions_boundary = var.sns_topic_feedback_role_permissions_boundary | |||
| assume_role_policy = data.aws_iam_policy_document.sns_feedback[0].json | |||
There was a problem hiding this comment.
part 1:
lets leave this as is
bryantbiggs
reviewed
Mar 21, 2024
iam.tf
Outdated
| @@ -31,7 +31,16 @@ resource "aws_iam_role" "sns_feedback_role" { | |||
| path = var.sns_topic_feedback_role_path | |||
| force_detach_policies = var.sns_topic_feedback_role_force_detach_policies | |||
| permissions_boundary = var.sns_topic_feedback_role_permissions_boundary | |||
| assume_role_policy = data.aws_iam_policy_document.sns_feedback[0].json | |||
| assume_role_policy = jsonencode({ | |||
| Version = "2012-10-17", | |||
There was a problem hiding this comment.
part 2:
Replace the permissions here with the permissions defined below
also, I guess this has been broken for 2 years?! 😅
There was a problem hiding this comment.
I am hoping you meant extend this with the inline permission that I had added ?
bryantbiggs
approved these changes
Mar 26, 2024
bryantbiggs
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Mar 26, 2024
## [6.1.2](v6.1.1...v6.1.2) (2024-03-26) ### Bug Fixes * Correct assume role permissions for SNS service to assume IAM role ([#220](#220)) ([dae0c0f](dae0c0f))
|
This PR is included in version 6.1.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the defined
assume_role_policywith an inline policy and with that the IAM policy for CloudWatch Logs is properly attached to the role, and a valid assume role policy is defined, granting AWS SNS the right to assume the role.Motivation and Context
Fixes #219
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request