fix: Revert breaking change on :zip command #645
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uncatchable-de
changed the title
uncatchable-de
changed the title
|
This issue has been resolved in version 7.16.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lambda 7.15.0 intorduced with #640 a breaking change. The
:zipcommand without any arguments is using the current working directory instead of the specifiedpathattribute. This breaks the examples from README.md, where the resulting zip files contains more files, with different paths. This PR reverts the change to use the specified path again.See issue #644 for a detailed description of the issue, including examples.
Motivation and Context
7.15.0 introduced a breaking change on ignoring the path when specifying the
:zipcommand.The PR that introduced the breaking change: #640
Breaking Changes
No, it reverts a breaking change from 7.15.0.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request