feat: Allow temp dir for poetry docker builds #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilandose
changed the title
|
@antonbabenko could I get a review on this when convenient, as this stops me from building layers in github action pipelines |
ahlinc
reviewed
Dec 1, 2024
examples/build-package/main.tf
Outdated
| @@ -426,6 +426,7 @@ module "lambda_layer_poetry" { | |||
| { | |||
| path = "${path.module}/../fixtures/python-app-poetry" | |||
| poetry_install = true | |||
| poetry_tmp_dir = "${path.root}/builds/" | |||
There was a problem hiding this comment.
Could you change this line similar to the bellow existing in examples?
I think it's better to keep the
builds/ folder with just the module generated content and doesn't give such advice in examples to use it for other purposes.
|
@antonbabenko this change looks good to me and my latest changes that did to rework the build plan approach doesn't interfere with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows optionally specifying a temp dir for poetry to bring parity with npm and pip
Motivation and Context
Docker CLI on ubuntu default for github actions, does not allow mounting /tmp https://stackoverflow.com/questions/65267251/docker-bind-mount-directory-in-tmp-not-working
This results in a frustrating situation where terraform passes locally but fails with strange error in CI pipeline.
Fixes: #545
Breaking Changes
N/A
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsAdded temp dir to one poetry example and left rest untouched to prove not breaking change
pre-commit run -aon my pull request