feat: Make compatible_runtimes optional, added sam metadata control
#493
Conversation
ajschmidt8
changed the title
compatible_runtimes optionalcompatible_runtimes optional
ajschmidt8
changed the title
compatible_runtimes optionalcompatible_runtimes optional
|
@antonbabenko, can you take a look at this when you have a moment? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
this is not stale. @antonbabenko, can you check on this PR soon? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
@antonbabenko, can you check on this PR? It addresses a legitimate bug. |
## [6.1.0](terraform-aws-modules/terraform-aws-lambda@v6.0.1...v6.1.0) (2023-10-27) ### Features * Allows tags to be provided only to the function ([terraform-aws-modules#508](terraform-aws-modules#508)) ([610d602](terraform-aws-modules@610d602))
antonbabenko
changed the title
compatible_runtimes optionalcompatible_runtimes optional, added sam metadata control
## [6.2.0](v6.1.0...v6.2.0) (2023-10-27) ### Features * Make `compatible_runtimes` optional, added sam metadata control ([#493](#493)) ([180da4c](180da4c))
|
This PR is included in version 6.2.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR makes the
compatible_runtimesargument for theaws_lambda_layer_versionresource optional.Motivation and Context
Currently, the
compatible_runtimesvalue is inferred fromvar.compatible_runtimesandvar.runtime.If neither of these values is set, the module throws an error.
I'm trying to use this module to publish a Lambda layer that doesn't depend on any particular runtime (it's just a plain-text configuration file).
Therefore, I'd expect that I'd be able to publish this layer without having to specify a runtime.
The official
aws_lambda_layer_versionresource docs mention that this argument is optional (see here), so I'd expect that it would be optional in this module as well.Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request