Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support maximum concurrency of Lambda Alias with SQS as an event source #457

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

Lfaufau
Copy link
Contributor

@Lfaufau Lfaufau commented May 9, 2023

Description

PR #402 introduced maximum concurrency to lambda functions.
As I use Aliases, I've added this feature to their module

This is also my first contribution to this repo.

Motivation and Context

Limiting lambda concurrency with SQS without setting reserved concurrency, while using Lambda Aliases

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jun 9, 2023
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Jun 20, 2023
@lfauchille
Copy link

not stale

@antonbabenko antonbabenko reopened this Jul 4, 2023
@antonbabenko antonbabenko merged commit 24bd26e into terraform-aws-modules:master Jul 4, 2023
antonbabenko pushed a commit that referenced this pull request Jul 4, 2023
## [5.1.0](v5.0.0...v5.1.0) (2023-07-04)

### Features

* Support maximum concurrency of Lambda Alias with SQS as an event source ([#457](#457)) ([24bd26e](24bd26e))
@antonbabenko
Copy link
Member

This PR is included in version 5.1.0 🎉

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants