-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Override docker entrypoint when it exists #316
fix: Override docker entrypoint when it exists #316
Conversation
This PR has been automatically marked as stale because it has been open 30 days |
This PR was automatically closed because of stale in 10 days |
Could we reopen this one and merge? I tested the change locally and it fixed building packages with the |
Hi Ben! Thank you for checking out this issue! Please take this fresh release and confirm that it works for you as expected. |
### [4.0.2](v4.0.1...v4.0.2) (2022-09-17) ### Bug Fixes * Override docker entrypoint when it exists ([#316](#316)) ([3bb7623](3bb7623))
This PR is included in version 4.0.2 🎉 |
Great, thanks so much! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Fixes #313
Description
When a base image contains an entrypoint path, it'll cause an
entrypoint requires the handler name to be the first argument
error to be thrown as the current run commend doesn't override it.Motivation and Context
See issue #313. I am not sure when it happened, but the official AWS lambda runtime images started including entrypoints (lambci images still do not).
Breaking Changes
Nope
How Has This Been Tested?
Tested and working on my personal project. Official tests still todo:
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request