feat: Add support to build automatically npm dependencies #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort. Change default docker image from lambci to offical AWS SAM images
maintux
changed the title
maintux
changed the title
antonbabenko
requested changes
Mar 26, 2022
README.md
Outdated
| }, { | ||
| path = "src/nodejs14.x-app1", | ||
| npm_requirements = true, | ||
| nom_tmp_dir = "/tmp/dir/location" |
There was a problem hiding this comment.
Suggested change
| nom_tmp_dir = "/tmp/dir/location" | |
| npm_tmp_dir = "/tmp/dir/location" |
|
I have finished it in #293 because I didn't have permission to push to your fork. |
|
This issue has been resolved in version 2.36.0 🎉 |
|
Top! Thanks :) |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As made for pip requirements, this PR adds support to build Nodejs dependencies automatically with or without docker.
Motivation and Context
This PR simplifies the process needed to build and deploy Nodejs functions and, thanks to docker, allows users to build functions without the need to have the interpreter installed locally
Breaking Changes
No breaking changes introduced
How Has This Been Tested?
examples/*projects