Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unique_id output of the lambda role #173

Merged
merged 5 commits into from
Aug 30, 2021
Merged

feat: Add unique_id output of the lambda role #173

merged 5 commits into from
Aug 30, 2021

Conversation

pglagerweij
Copy link
Contributor

Description

Added unique_id output of the created lambda role.

Motivation and Context

We have s3 bucket policies that use the unique role id to restrict access to specific roles. This make sure I can create the lambda role with the module instead of creating the role separately or using a data resource to get the required variable.

Breaking Changes

Doesn't break anything as far as I am aware.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    Applied this using terraform 13.4 and 1.0 and used the output of this feature

@pglagerweij pglagerweij changed the title add unique_id output add unique_id output to the lambda role Jul 13, 2021
update description to properly say unique id
@pglagerweij pglagerweij changed the title add unique_id output to the lambda role feat:add unique_id output to the lambda role Jul 13, 2021
@pglagerweij pglagerweij changed the title feat:add unique_id output to the lambda role feat: add unique_id output to the lambda role Jul 13, 2021
@pglagerweij pglagerweij changed the title feat: add unique_id output to the lambda role feat: add unique_id output of the lambda role Jul 13, 2021
@antonbabenko antonbabenko changed the title feat: add unique_id output of the lambda role feat: Add unique_id output of the lambda role Aug 30, 2021
@antonbabenko antonbabenko merged commit ba4dbbb into terraform-aws-modules:master Aug 30, 2021
@antonbabenko
Copy link
Member

Thanks, @pglagerweij for the PR!

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants