Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to build automatically npm dependencies #293

Merged
merged 9 commits into from
Mar 26, 2022

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Mar 26, 2022

Fully based on #292 where I didn't have permission to push changes. Fixes #292.

  1. Add support to build automatically npm dependencies, with docker support.
  2. Change default docker image from lambci to official AWS SAM images

Description

As made for pip requirements, this PR adds support to build Nodejs dependencies automatically with or without docker.

Motivation and Context

This PR simplifies the process needed to build and deploy Nodejs functions and, thanks to docker, allows users to build functions without the need to have the interpreter installed locally

Breaking Changes

No breaking changes introduced

How Has This Been Tested?

  • [ x ] I have tested and validated these changes using one or more of the provided examples/* projects
  • [ x ] I have also tested the real deployment of Python and Nodejs functions with and without dependencies.

@antonbabenko antonbabenko merged commit ecb3807 into master Mar 26, 2022
@antonbabenko antonbabenko deleted the npm-support branch March 26, 2022 20:09
antonbabenko pushed a commit that referenced this pull request Mar 26, 2022
## [2.36.0](v2.35.1...v2.36.0) (2022-03-26)

### Features

* Add support to build automatically npm dependencies ([#293](#293)) ([ecb3807](ecb3807))
@antonbabenko
Copy link
Member Author

This PR is included in version 2.36.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant