Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): add permission to create log group #100

Merged
merged 5 commits into from
Jan 26, 2021
Merged

fix(iam): add permission to create log group #100

merged 5 commits into from
Jan 26, 2021

Conversation

svenlito
Copy link
Contributor

Description

add iam CreateLogGroup permission

Motivation and Context

To be in line with the AWSLambdaBasicExecutionRole.

iam.tf Outdated Show resolved Hide resolved
iam.tf Outdated
"logs:CreateLogStream",
"logs:PutLogEvents",
]
], compact([!var.use_existing_cloudwatch_log_group ? "logs:CreateLogGroup" : ""]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko not sure if this is ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, e9ef635

@antonbabenko antonbabenko merged commit 7c63eeb into terraform-aws-modules:master Jan 26, 2021
@antonbabenko
Copy link
Member

v1.35.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants