Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iam): add permission to create log group #100

Merged
merged 5 commits into from
Jan 26, 2021
Merged

fix(iam): add permission to create log group #100

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc7a53e
fix(iam): add permission to create log group
Jan 26, 2021
59a2b77
fix(iam): add permission to create log group"
Jan 26, 2021
63f3ec0
revert(tf): formatter change
Jan 26, 2021
8c13a6e
refactor(iam): add action if no custom log group
Jan 26, 2021
e9ef635
Simplified expression a bit
antonbabenko Jan 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions iam.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,10 @@ data "aws_iam_policy_document" "logs" {
statement {
effect = "Allow"

actions = [
actions = concat([
"logs:CreateLogStream",
"logs:PutLogEvents",
]
], compact([!var.use_existing_cloudwatch_log_group ? "logs:CreateLogGroup" : ""]))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko not sure if this is ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, e9ef635


resources = flatten([for _, v in ["%v:*", "%v:*:*"] : format(v, local.log_group_arn)])
}
Expand Down