Skip to content

Commit

Permalink
No need to set etag as the filename is a hash of the content that onl…
Browse files Browse the repository at this point in the history
…y changes when the actual content changes, while the computed etag was a MD5 hash of the locally built zip archive which always changed
  • Loading branch information
pdecat committed Jul 15, 2021
1 parent 185858d commit 67537f6
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,6 @@ resource "aws_s3_bucket_object" "lambda_package" {
acl = var.s3_acl
key = data.external.archive_prepare[0].result.filename
source = data.external.archive_prepare[0].result.filename
etag = fileexists(data.external.archive_prepare[0].result.filename) ? filemd5(data.external.archive_prepare[0].result.filename) : null
storage_class = var.s3_object_storage_class

server_side_encryption = var.s3_server_side_encryption
Expand Down

0 comments on commit 67537f6

Please sign in to comment.