fix: Reduce required versions for Terraform and AWS provider

[bryantbiggs]

Description

• Reduce required versions for Terraform and AWS provider

Motivation and Context

• Since this module was created to both stand on its own as well as embed into other modules that utilize KMS keys, the version will need to support the minimum of those other modules its embedded into (i.e. - Terraform init failing for terraform version < 1.X terraform-aws-eks#2126)

Breaking Changes

• No since we are reducing the version requirements (expanding capability) and there isn't anything required by the configs used to dictate v4.0 or Terraform v1.0 (was just picked as the current "starting point")

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

@antonbabenko

[junaid-ali]

@bryantbiggs I'm wondering that instead of downgrading the other versions, if we need to update the terraform version in this repo: https://github.com/terraform-aws-modules/terraform-aws-kms/blob/master/versions.tf#L2

[bryantbiggs]

no. because I added the KMS module to the EKS module terraform-aws-modules/terraform-aws-eks#2121 - that is what is forcing the overall EKS module to require Terraform v1.0+

There isn't anything in this module that requires Terraform v1.0+ or AWS v4.0+, those are just the "defaults" I start with on modules these days. But since this module is embedded in other modules, we have to ensure it meets the minimum. Therefore, reducing its required versions here, and the bumping the version used on the EKS module - that will put the EKS module back on par with the versions it uses today. We don't want to bump those because that would incur a major release due to breaking changes (more restrictions)

[antonbabenko]

I like this PR because, as you say, it is a small resource module which is used in a bigger/EKS one.

[bryantbiggs]

ah, we didn't add this repo under meta yet - @antonbabenko are you able to merge this one when you get a chance 🙏🏽

[antonbabenko]

This PR is included in version 1.0.1 🎉

[antonbabenko]

@bryantbiggs I have just fixed permissions for KMS and global accelerator module you imported a few weeks ago.

[bryantbiggs]

awesome, thank you!

[junaid-ali]

no. because I added the KMS module to the EKS module terraform-aws-modules/terraform-aws-eks#2121 - that is what is forcing the overall EKS module to require Terraform v1.0+

There isn't anything in this module that requires Terraform v1.0+ or AWS v4.0+, those are just the "defaults" I start with on modules these days. But since this module is embedded in other modules, we have to ensure it meets the minimum. Therefore, reducing its required versions here, and the bumping the version used on the EKS module - that will put the EKS module back on par with the versions it uses today. We don't want to bump those because that would incur a major release due to breaking changes (more restrictions)

Oh sorry, I thought the PR was in the terraform-aws-eks repo 😅

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.