Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add elasticloadbalancing:AddTags permissions to AWS Load Balancer Controller policy required for version 2.4.7+ #358

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

michelzanini
Copy link
Contributor

@michelzanini michelzanini commented Mar 27, 2023

Add elasticloadbalancing:AddTags permissions to AWS Load Balancer Controller policy required for version 2.4.7

Description

Version 2.4.7 of AWS ALB controller has been released with an updated IAM permission https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.4.7.

The permission required is elasticloadbalancing:AddTags. See change here https://github.com/kubernetes-sigs/aws-load-balancer-controller/pull/3046/files.

Motivation and Context

Updates AWS ALB Controller policy to match latest on version 2.4.7.

Breaking Changes

None.

How Has This Been Tested?

I have applied the IAM policy to AWS using Terraform, then copied the resulting JSON file from AWS, and did a file side-by-side comparison with the official IAM policy JSON confirming it matches.

Fixes #339

…r Controller policy required for version 2.4.7
@bryantbiggs bryantbiggs changed the title fix: Add elasticloadbalancing:AddTags permissions to AWS Load Balancer Controller policy required for version 2.4.7 feat: Add elasticloadbalancing:AddTags permissions to AWS Load Balancer Controller policy required for version 2.4.7+ Mar 27, 2023
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit e1403c1 into terraform-aws-modules:master Mar 27, 2023
antonbabenko pushed a commit that referenced this pull request Mar 27, 2023
## [5.16.0](v5.15.0...v5.16.0) (2023-03-27)

### Features

* Add `elasticloadbalancing:AddTags` permissions to AWS Load Balancer Controller policy required for version 2.4.7+ ([#358](#358)) ([e1403c1](e1403c1))
@antonbabenko
Copy link
Member

This PR is included in version 5.16.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants