feat: Add a homemade depends_on for MNG submodule to ensure ordering of resource creation
#867
Conversation
barryib
changed the title
depends_on for MNG submodule to ensure ordering of resource creationdepends_on for MNG submodule to ensure ordering of resource creation
|
closing in favor of #868 |
There was a problem hiding this comment.
Please could we reconsider this?
It is a more terraform native way of ensuring dependency between resources.
I really regret the null_resource hack as I didn't know that you could just depend on variables! We're seeing this horror being repeated in the PRs for moving workers to a module and fargate support.
modules/node_groups/variables.tf
Outdated
| @@ -34,3 +34,11 @@ variable "node_groups" { | |||
| type = any | |||
| default = {} | |||
| } | |||
|
|
|||
| # Hack for a homemade `depends_on` https://discuss.hashicorp.com/t/tips-howto-implement-module-depends-on-emulation/2305/2 | |||
| # Will be removed when Terraform will add support of module's `depends_on`https://github.com/hashicorp/terraform/issues/10462 | |||
There was a problem hiding this comment.
The module cannot depend on the aws_auth. Output from the module is used to generate the configmap's roles key.
There was a problem hiding this comment.
Humm after reading some issues, I think your comment #852 (comment) still apply. Terraform won't go into dependency cycle because the aws_auth_roles output from MNG is built with locals.
Yes of course. I will rebase my branch. |
barryib
force-pushed
the
tba/node-groups-depends-on
branch
from
8c3409b to
74efdb2
Compare
…of resource creation
barryib
force-pushed
the
tba/node-groups-depends-on
branch
from
74efdb2 to
dc959f2
Compare
…g of resource creation (terraform-aws-modules#867)
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Hack to add a "homemade" depends_on as suggested https://discuss.hashicorp.com/t/tips-howto-implement-module-depends-on-emulation/2305/2 to ensure ordering of ressource creation for managed node groups.
I don't really like the approach, but the hack doesn't add complexity (because, there are only 2 resources in the submodule in which we add an explicit
depends_on) and seems to work as expected.I tested it to resolves #843
Note: I'm opening this PR to start discussion. So feedbacks are welcomed.
Questions
Checklist