Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move all locals in locals.tf #865

Conversation

barryib
Copy link
Member

@barryib barryib commented May 6, 2020

PR o'clock

Description

Move locals in locals.tf

Checklist

Copy link
Contributor

@dpiddockcmp dpiddockcmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barryib barryib force-pushed the tba/chore-locals-in-localstf branch from 5648965 to f2ec4e1 Compare May 6, 2020 11:57
@barryib barryib merged commit 9bfdba9 into terraform-aws-modules:master May 6, 2020
@barryib barryib deleted the tba/chore-locals-in-localstf branch May 6, 2020 12:00
dpiddockcmp pushed a commit to dpiddock/terraform-aws-eks that referenced this pull request May 15, 2020
dpiddockcmp added a commit that referenced this pull request Jun 5, 2020
Broke use case of passing in custom template content. Reverts most of the following PRs:
- #865
- #863 
- #854
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
Broke use case of passing in custom template content. Reverts most of the following PRs:
- terraform-aws-modules#865
- terraform-aws-modules#863 
- terraform-aws-modules#854
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants