Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kitchen test for terraform 0.12.x #788

Closed

Conversation

bigwheel
Copy link

@bigwheel bigwheel commented Mar 13, 2020

PR o'clock

Description

Fix kitchen test for terraform 0.12.x.

Test codes are written 6 months ago and it was broken because it supported only terraform 0.11.x.
In 6 months, eks module's least support version bumped to 0.12.x therefore test codes didn't work completely.

This PR ups test library versions and fix broken point.

Checklist

  • Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
    • I think no need to do it
  • CI tests are passing
    • Unfortunately, in this module CI test is not running. The test with real AWS resources need real money.
  • README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation
    • no need

@bigwheel
Copy link
Author

bigwheel commented Mar 13, 2020

P.S.

I think that gruntwork-io/terratest is best may be good for terraform module test.
But, firstly I fix existing test.

@max-rocket-internet
Copy link
Contributor

I opened a PR to just remove the kitchen stuff #787

I don't think it's valuable. Would you agree?

@bigwheel
Copy link
Author

@max-rocket-internet
Basically agree.
I believe terraform test is valuable but terraform-aws-eks couldn't use it well.
Let's remove.

@bigwheel bigwheel closed this Mar 13, 2020
@bigwheel bigwheel deleted the fix-kitchen-test branch March 13, 2020 14:05
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants