Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: automate changelog management #786

Merged

Conversation

barryib
Copy link
Member

@barryib barryib commented Mar 12, 2020

PR o'clock

Description

This is a first draft to get feedbacks. There are still some questions about:

cc @max-rocket-internet @antonbabenko @js-timbirkett

Resolves #781

Todo

  • Manage old changelog (Should be added in template ?)
  • Avoid adding "Update changelog" or new release commits in the changelog
  • Tests to ensure that no one modify the changelog in PRs (don't know yet how to comment back to the PR)
  • Use https://github.com/apps/semantic-pull-requests (config ok, have to add the github app)
  • Update contribution guide

Makefile Outdated Show resolved Hide resolved
tools/semtag Show resolved Hide resolved
@barryib
Copy link
Member Author

barryib commented Mar 13, 2020

@antonbabenko @js-timbirkett With your experience with git-chglog, do you have any advice for these questions ?

  • How to manage old changelog ? Put it in the template ?
  • How can I skip new release commits (or "update changelog") in the changelog ? Use skip/changelog commit prefix ?
  • Ho to ensure that PR titles follow gidelines ? Use something like https://github.com/apps/semantic-pull-requests ?

@antonbabenko
Copy link
Member

I don't have a lot of advanced experience with git-chglog but here are my thoughts:

  1. I would put the current changelog into changelog-before-10.md or something like that, and use the tool for the whole changelog creation with the default template.
  2. Maybe we can amend git commits, but I am not sure how to do this for various scenarios. I agree that it does not look nice to have that one commit every time, but I don't know a good solution.
  3. We can enable that GitHub app to give it a try and see what happens.

@barryib
Copy link
Member Author

barryib commented Mar 13, 2020

How to manage old changelog ? Put it in the template ?

I've wrote a small makefile which generate changelog with git-chglog and replace <!-- BEGIN GIT-CHGLOG --><!-- END GIT-CHGLOG --> in the changelog file.

@barryib barryib force-pushed the tba-automate-changelog branch from 3211d4e to dcbaa0c Compare March 14, 2020 13:27
@barryib
Copy link
Member Author

barryib commented Mar 14, 2020

@max-rocket-internet @antonbabenko So far here are my feebacks and propositions:

  • How to manage old changelog ? Put it in the template ?

I use placeholders in the CHANGELOG.md file and replace it with the generated changelog from git tag v10.0.0

  • How can I skip new release commits (or "update changelog") in the changelog ? Use skip/changelog commit prefix ?

Using skip as PR or commit prefix and I don't catch them in git-chglog configuration.

I'll try this bot during the weekend.

Tests to ensure that no one modify the changelog in PRs

For now I don't know why, but unsplash/comment-on-pr@master is failling to add comments to the PR. Sounds like the secrets.GITHUB_TOKEN doesn't have permission for comment 🤔 .

@barryib barryib changed the title automate changelog management WIP: automate changelog management Mar 15, 2020
@barryib barryib force-pushed the tba-automate-changelog branch from 955cb72 to 857eb61 Compare March 15, 2020 21:30
@barryib barryib changed the title WIP: automate changelog management automate changelog management Mar 15, 2020
.chglog/CHANGELOG.tpl.md Outdated Show resolved Hide resolved
.chglog/CHANGELOG.tpl.md Outdated Show resolved Hide resolved
.github/semantic.yml Outdated Show resolved Hide resolved
@barryib barryib changed the title automate changelog management improvement: automate changelog management Mar 16, 2020
@barryib
Copy link
Member Author

barryib commented Mar 16, 2020

@max-rocket-internet After some discussions with @antonbabenko, we decided to move the old changelog into a different file. So the CHANGELOG.md will contain every release notes from v11.0.0 and will be generated from git commits. Are you ok with that ?

@barryib barryib changed the title improvement: automate changelog management automate changelog management Mar 17, 2020
@barryib barryib changed the title automate changelog management improvement: automate changelog management Mar 17, 2020
@barryib barryib merged commit 9fb1a20 into terraform-aws-modules:master Mar 17, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some automation for changelog management
3 participants