-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release 10.0.0 #780
New release 10.0.0 #780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update this file: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/version
@antonbabenko is this file even used? https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/version |
All sounds great 👍 Unrelated but I just create this issue: #781 |
I don't think the |
Aight then, @barryib let's just delete that file 🙂 |
Done. |
2c8127b
to
dbf31ab
Compare
Wicked! Thank you @max-rocket-internet @barryib |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
PR o'clock
Description
Prepare for new release.
@max-rocket-internet I added enhancements and bug fixes section for new release. Furthermore I propose to use git PR id with link
(GH-xxxx)
instead of(by @you)
. I think that PR reference is more is more usefull than the author name. I'll add a kind of script from hashicorp/terraform to update link before a new release.What do you think ?
Checklist