Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 10.0.0 #780

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

barryib
Copy link
Member

@barryib barryib commented Mar 12, 2020

PR o'clock

Description

Prepare for new release.

@max-rocket-internet I added enhancements and bug fixes section for new release. Furthermore I propose to use git PR id with link (GH-xxxx) instead of (by @you). I think that PR reference is more is more usefull than the author name. I'll add a kind of script from hashicorp/terraform to update link before a new release.

What do you think ?

Checklist

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-rocket-internet
Copy link
Contributor

@max-rocket-internet
Copy link
Contributor

What do you think ?

All sounds great 👍

Unrelated but I just create this issue: #781

@antonbabenko
Copy link
Member

I don't think the version file is used for anything good.

@max-rocket-internet
Copy link
Contributor

Aight then, @barryib let's just delete that file 🙂

@barryib
Copy link
Member Author

barryib commented Mar 12, 2020

Aight then, @barryib let's just delete that file 🙂

Done.

@barryib barryib merged commit ca3d1e1 into terraform-aws-modules:master Mar 12, 2020
@barryib barryib deleted the tba-release-10.0.0 branch March 12, 2020 12:29
@sc250024
Copy link
Contributor

Wicked! Thank you @max-rocket-internet @barryib

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants