change default value for wait_for_cluster_cmd

[daroga0002]

PR o'clock

Description

This is addressing #741

Currently after creating eks cluster there is local-exec loop checking availability of API endpoint

terraform-aws-eks/variables.tf

Lines 201 to 205 in 10ca272

	variable "wait_for_cluster_cmd" {
	description = "Custom local-exec command to execute for determining if the eks cluster is healthy. Cluster endpoint will be available as an environment variable called ENDPOINT"
	type = string
	default = "until curl -k -s $ENDPOINT/healthz >/dev/null; do sleep 4; done"
	}

This behaviour is working totally fine, but it require installed curl, which is missing in official Hashicorp docker image ( hashicorp/terraform ). Instead there is wget:

$ docker run -ti --entrypoint='' hashicorp/terraform sh
/ # which curl 
/ # which wget
/usr/bin/wget

This can be workaround by using following input module variable:

wait_for_cluster_cmd = "until wget --no-check-certificate -O - -q $ENDPOINT/healthz >/dev/null; do sleep 4; done"

So proposing to switch default to wget what will allow running module in automated CI processes using Hashicorp docker environment.

Checklist

• [ x] Change added to CHANGELOG.md. All changes must be added and breaking changes and highlighted
• [ x] CI tests are passing
• [ x] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[max-rocket-internet]

So proposing to switch default to wget what will allow running module in automated CI processes using Hashicorp docker environment.

Awesome 👍

[max-rocket-internet]

Thanks @daroga0002 💛

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.