Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set the name of a node group manually #739

Merged

Conversation

splieth
Copy link
Contributor

@splieth splieth commented Feb 14, 2020

PR o'clock

Description

I added an additional parameter name to managed node groups in order to be able to manually provide a name for the node group. Resolves #698.

Checklist

Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @splieth!

@max-rocket-internet max-rocket-internet merged commit 10ca272 into terraform-aws-modules:master Feb 14, 2020
@barryib barryib mentioned this pull request May 20, 2020
2 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto rotate managed node groups by setting node group name
2 participants