-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for EKS Auto Mode and EKS Hybrid nodes #3225
feat: Add support for EKS Auto Mode and EKS Hybrid nodes #3225
Conversation
Waiting to try this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good and very detailed examples! 💪
My questions are minor and very much optional.
README.md
Outdated
|
||
When enabling `authentication_mode = "API_AND_CONFIG_MAP"`, EKS will automatically create an access entry for the IAM role(s) used by managed node group(s) and Fargate profile(s). There are no additional actions required by users. For self-managed node groups and the Karpenter sub-module, this project automatically adds the access entry on behalf of users so there are no additional actions required by users. | ||
|
||
On clusters that were created prior to CAM support, there will be an existing access entry for the cluster creator. This was previously not visible when using `aws-auth` ConfigMap, but will become visible when access entry is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is CAM support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CAM = cluster access management. I'll update to use the expanded form for clarity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected in c24470b
examples/eks-hybrid-nodes/main.tf
Outdated
hybrid-all = { | ||
cidr_blocks = [local.remote_network_cidr] | ||
description = "Allow all traffic from remote node/pod network" | ||
from_port = "-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be a number like in the top block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was able to remove these since the protocol is all
we'll go ahead and merge this since it supports creating clusters with EKS Auto Mode and EKS Hybrid nodes, and also supports opting into EKS Auto Mode - the only scenario which is not support at this time is opting into EKS Auto Mode utilizing the built-in nodepools ( |
## [20.31.0](v20.30.1...v20.31.0) (2024-12-04) ### Features * Add support for EKS Auto Mode and EKS Hybrid nodes ([#3225](#3225)) ([3b974d3](3b974d3))
This PR is included in version 20.31.0 🎉 |
Description
system
and/orgeneral-purpose
enable_security_groups_for_pods
to maintain current cluster IAM role policy behavior; this can be disabled for those not using security groups for pods. This variable and the attachment of theAmazonEKSVPCResourceController
policy will be removed in the next breaking changeMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request