feat: Propagate ami_type to self-managed node group; allow using ami_type only
#3030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
commented
May 7, 2024
| ssm_cluster_version = var.cluster_version != null ? var.cluster_version : "" | ||
|
|
||
| # TODO - Temporary stopgap for backwards compatibility until v21.0 | ||
| ami_type_to_user_data_type = { |
There was a problem hiding this comment.
in v21, we can look at consolidating these repeated lookup maps in another helper sub-module like the user-data. but for now, a little bit of duplication is ok while we roll it out and ensure we maintain backwards compatibility
3 tasks
antonbabenko
approved these changes
May 8, 2024
antonbabenko
pushed a commit
that referenced
this pull request
May 8, 2024
## [20.9.0](v20.8.5...v20.9.0) (2024-05-08) ### Features * Propagate `ami_type` to self-managed node group; allow using `ami_type` only ([#3030](#3030)) ([74d3918](74d3918))
|
This PR is included in version 20.9.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ami_typedown to the self-managed nodegroup. This allows users to specify just theami_typeinstead of needing to specify theami_typeand theplatform(which is redundantly annoying). Theplatformfunctionality is still preserved for backwards compatibility until its removed in the next major version releasecluster_service_cidroutput; previously it would output either the IPv4 CIDR ornull, which is incorrect for IPv6 clustersMotivation and Context
Breaking Changes
masterand then switching to this branch to check the diffHow Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request