fix: Remove additional conditional on Karpenter instance profile creation to support upgrading #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion to support upgrading
antonbabenko
approved these changes
Nov 10, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Nov 10, 2023
### [19.19.1](v19.19.0...v19.19.1) (2023-11-10) ### Bug Fixes * Remove additional conditional on Karpenter instance profile creation to support upgrading ([#2812](#2812)) ([c36c8dc](c36c8dc))
|
This PR is included in version 19.19.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
create_instance_profile), we are removing the additional conditional added in feat: Add Karpenter v1beta1 compatibility #2800 to allow users to opt into the new permissions required for 0.32, and then later opt out of the module created instance profile once they feel its safe to do so (i.e. - after all nodes have been replaced with nodes using the Karpenter created instance profile)Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request