Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Ignore changes to *.aws_iam_role.*.role_last_used #2628

Merged
merged 3 commits into from
May 24, 2023
Merged

feat: Ignore changes to *.aws_iam_role.*.role_last_used #2628

merged 3 commits into from
May 24, 2023

Conversation

yurrriq
Copy link
Contributor

@yurrriq yurrriq commented May 24, 2023 •
edited
Loading

Description

Ignore changes to role_last_used for aws_iam_role.this[0], module.eks_managed_node_group[*].aws_iam_role.this[0], and module.eks_managed_node_group[*].aws_iam_role.irsa[0].

Motivation and Context

Without this commit, there is useless noise in drift detection in Terraform Enterprise, for example.

Breaking Changes

I shouldn't think so.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

can you provide a reproduction that shows this reoccurring issue within plans and applies? this is the first I am hearing of this being an issue

@yurrriq yurrriq force-pushed the ignore_changes-role_last_used branch from c1dc828 to 3af0126 Compare May 24, 2023 16:56
@yurrriq yurrriq changed the title feat: ignore changes to *.aws_iam_role.*.role_last_used feat: Ignore changes to *.aws_iam_role.*.role_last_used May 24, 2023
@yurrriq
Copy link
Contributor Author

yurrriq commented May 24, 2023 •
edited
Loading

Sure, I'll try. Maybe this is something TFE specific, so I updated the description.

@yurrriq
Copy link
Contributor Author

yurrriq commented May 24, 2023

Nothing sensitive really, but I messaged you an example on the AWS Developers Slack.

@bryantbiggs
Copy link
Member

Related upstream issue hashicorp/terraform-provider-aws#30861

bryantbiggs
bryantbiggs approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related upstream issue linked - this should be rather safe to accept here

@bryantbiggs bryantbiggs merged commit f8ea3d0 into terraform-aws-modules:master May 24, 2023
antonbabenko pushed a commit that referenced this pull request May 24, 2023
@semantic-release-bot
chore(release): version 19.15.0 [skip ci]
b168c1b 
## [19.15.0](v19.14.0...v19.15.0) (2023-05-24)

### Features

* Ignore changes to *.aws_iam_role.*.role_last_used ([#2628](#2628)) ([f8ea3d0](f8ea3d0))
@antonbabenko
Copy link
Member

This PR is included in version 19.15.0 🎉

@eli-kaplan
Copy link

Seems to produce an error:

Error: Unsupported attribute
 
   on .terraform/modules/kubernetes.eks/main.tf line 324, in resource "aws_iam_role" "this":
  324:       role_last_used,
 
 This object has no argument, nested block, or exported attribute named
 "role_last_used".`

@bryantbiggs
Copy link
Member

ya, my apologies - the attribute being ignored as added in 4.64 of the provider and I overlooked this. We will revert since it appears this is not resolving the underlying issue and will chase the upstream issue for resolution

@bryantbiggs bryantbiggs mentioned this pull request May 24, 2023
Merged
3 tasks
@yurrriq yurrriq deleted the ignore_changes-role_last_used branch May 25, 2023 16:38
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurrriq @bryantbiggs @antonbabenko @eli-kaplan