feat: Add additional port for metrics-server to recommended rules
#2353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
approved these changes
Dec 18, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Dec 18, 2022
## [19.3.0](v19.2.0...v19.3.0) (2022-12-18) ### Features * Add additional port for `metrics-server` to recommended rules ([#2353](#2353)) ([5a270b7](5a270b7))
|
This PR is included in version 19.3.0 🎉 |
pavlospt
reviewed
Dec 18, 2022
| @@ -115,6 +115,16 @@ locals { | |||
| type = "ingress" | |||
| self = true | |||
| } | |||
| # metrics-server | |||
| ingress_cluster_8443_webhook = { | |||
There was a problem hiding this comment.
@bryantbiggs 8443 is typo in the SG name!
There was a problem hiding this comment.
gosh dangit - thanks!
There was a problem hiding this comment.
#2354 should resolve - thanks for catching
3 tasks
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
## [19.3.0](terraform-aws-modules/terraform-aws-eks@v19.2.0...v19.3.0) (2022-12-18) ### Features * Add additional port for `metrics-server` to recommended rules ([terraform-aws-modules#2353](terraform-aws-modules#2353)) ([5a270b7](terraform-aws-modules@5a270b7))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
metrics-serverto recommended rulesMotivation and Context
metrics-serveris a common utility in EKS clustersBreaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request