-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name #2328
fix: Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name #2328
Conversation
… to avoid key lookup error on local variable
… still using a custom template
…ter name, such as using random provider resources
… KMS key for secret encryption
### [19.0.4](v19.0.3...v19.0.4) (2022-12-07) ### Bug Fixes * Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name ([#2328](#2328)) ([b83f6d9](b83f6d9))
This PR is included in version 19.0.4 🎉 |
We still ran into this error even thought we were on the fixed version so I feel there is more to it, as an alternative and if someone else ends up here please be aware you can use your own KMS key:
|
…nabled, support computed values in cluster name (terraform-aws-modules#2328) Co-authored-by: Bryant Biggs <[email protected]> Resolves undefined Resolved undefined Closes undefined
### [19.0.4](terraform-aws-modules/terraform-aws-eks@v19.0.3...v19.0.4) (2022-12-07) ### Bug Fixes * Ensure that custom KMS key is not created if encryption is not enabled, support computed values in cluster name ([terraform-aws-modules#2328](terraform-aws-modules#2328)) ([b83f6d9](terraform-aws-modules@b83f6d9))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request