Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update TLS provider and remove unnecessary cloud init version requirements #1966

Merged
merged 3 commits into from
Mar 25, 2022
Merged

feat: Update TLS provider and remove unnecessary cloud init version requirements #1966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e167fb
feat: Update TLS provider and remove unecessary cloud init version re…
bryantbiggs Mar 24, 2022
774194a
chore: remove network interface block from example due index error
bryantbiggs Mar 24, 2022
bf45e14
chore: add note on network interface bug
bryantbiggs Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,14 +807,14 @@ Full contributing [guidelines are covered here](https://github.com/terraform-aws
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.72 |
| <a name="requirement_tls"></a> [tls](#requirement\_tls) | >= 2.2 |
| <a name="requirement_tls"></a> [tls](#requirement\_tls) | >= 3.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | >= 3.72 |
| <a name="provider_tls"></a> [tls](#provider\_tls) | >= 2.2 |
| <a name="provider_tls"></a> [tls](#provider\_tls) | >= 3.0 |

## Modules

Expand Down
9 changes: 5 additions & 4 deletions examples/eks_managed_node_group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,10 +568,11 @@ resource "aws_launch_template" "external" {
enabled = true
}

network_interfaces {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this example started complaining about setting a device index so just removing since its not required for the example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in the AWS provider about it - hashicorp/terraform-provider-aws#23766

We hit it in one of the projects but I don't remember the resolution (probably downgraded version). Maybe leave a comment around this section with the link to the issue, so we know what was it in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good to know - thought I was losing it 😅

Added back the block but commented it out with a link to the issue - bf45e14

associate_public_ip_address = false
delete_on_termination = true
}
# Disabling due to https://github.com/hashicorp/terraform-provider-aws/issues/23766
# network_interfaces {
# associate_public_ip_address = false
# delete_on_termination = true
# }

# if you want to use a custom AMI
# image_id = var.ami_id
Expand Down
1 change: 0 additions & 1 deletion modules/eks-managed-node-group/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ module "eks_managed_node_group" {
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.72 |
| <a name="requirement_cloudinit"></a> [cloudinit](#requirement\_cloudinit) | >= 2.0 |

## Providers

Expand Down
4 changes: 0 additions & 4 deletions modules/eks-managed-node-group/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,5 @@ terraform {
source = "hashicorp/aws"
version = ">= 3.72"
}
cloudinit = {
source = "hashicorp/cloudinit"
version = ">= 2.0"
}
}
}
1 change: 0 additions & 1 deletion modules/self-managed-node-group/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ module "self_managed_node_group" {
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.1 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 3.72 |
| <a name="requirement_cloudinit"></a> [cloudinit](#requirement\_cloudinit) | >= 2.0 |

## Providers

Expand Down
4 changes: 0 additions & 4 deletions modules/self-managed-node-group/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,5 @@ terraform {
source = "hashicorp/aws"
version = ">= 3.72"
}
cloudinit = {
source = "hashicorp/cloudinit"
version = ">= 2.0"
}
}
}
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ terraform {
}
tls = {
source = "hashicorp/tls"
version = ">= 2.2"
version = ">= 3.0"
}
}
}